fix: Add retry for eventual consistency bug in aws_iot_policy #34329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of CreateDate
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/S
terraform-aws-provider
bot
added
the
needs-triage
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @Octogonapus 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
ewbankkit
added
eventual-consistency
…rsionId instead of CreateDate" This reverts commit 5d528f6.
…rce update" This reverts commit 9852ae0.
…x number is reached" This reverts commit 784897a.
% make testacc TESTARGS='-run=TestAccIoTPolicy_' PKG=iot ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run=TestAccIoTPolicy_ -timeout 360m === RUN TestAccIoTPolicy_basic === PAUSE TestAccIoTPolicy_basic === RUN TestAccIoTPolicy_disappears === PAUSE TestAccIoTPolicy_disappears === CONT TestAccIoTPolicy_basic === CONT TestAccIoTPolicy_disappears --- PASS: TestAccIoTPolicy_disappears (19.19s) --- PASS: TestAccIoTPolicy_basic (24.35s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 29.768s
% make testacc TESTARGS='-run=TestAccIoTPolicy_' PKG=iot ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run=TestAccIoTPolicy_ -timeout 360m === RUN TestAccIoTPolicy_basic === PAUSE TestAccIoTPolicy_basic === RUN TestAccIoTPolicy_disappears === PAUSE TestAccIoTPolicy_disappears === RUN TestAccIoTPolicy_update === PAUSE TestAccIoTPolicy_update === CONT TestAccIoTPolicy_basic === CONT TestAccIoTPolicy_update --- PASS: TestAccIoTPolicy_basic (32.82s) === CONT TestAccIoTPolicy_disappears --- PASS: TestAccIoTPolicy_update (48.98s) --- PASS: TestAccIoTPolicy_disappears (17.41s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 57.992s
…efault version of the policy if creating a new version would exceed the maximum number of versions (5).
ewbankkit
added
the
enhancement
github-actions
bot
added
size/XL
ewbankkit
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccIoTPolicy_' PKG=iot ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run=TestAccIoTPolicy_ -timeout 360m
=== RUN TestAccIoTPolicy_basic
=== PAUSE TestAccIoTPolicy_basic
=== RUN TestAccIoTPolicy_disappears
=== PAUSE TestAccIoTPolicy_disappears
=== RUN TestAccIoTPolicy_update
=== PAUSE TestAccIoTPolicy_update
=== RUN TestAccIoTPolicy_prune
=== PAUSE TestAccIoTPolicy_prune
=== CONT TestAccIoTPolicy_basic
=== CONT TestAccIoTPolicy_update
--- PASS: TestAccIoTPolicy_basic (24.73s)
=== CONT TestAccIoTPolicy_prune
--- PASS: TestAccIoTPolicy_update (41.53s)
=== CONT TestAccIoTPolicy_disappears
--- PASS: TestAccIoTPolicy_disappears (18.50s)
--- PASS: TestAccIoTPolicy_prune (113.81s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 143.701s% make testacc TESTARGS='-run=TestAccIoTPolicyAttachment_' PKG=iot ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run=TestAccIoTPolicyAttachment_ -timeout 360m
=== RUN TestAccIoTPolicyAttachment_basic
--- PASS: TestAccIoTPolicyAttachment_basic (65.89s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 71.572s
|
@Octogonapus Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds retries into the delete logic for
aws_iot_policy.This resource currently has a bug where it can fail to delete because a just-deleted policy attachment
has not yet propagated through AWS's system.
These retries have been added to fix that bug.
Relations
Closes #9541.
Relates #9540.
Closes #30314.
Closes #24979.
References
The AWS API documentation notes that it can take up to five minutes after a policy is detached before it's ready to be deleted: https://docs.aws.amazon.com/iot/latest/apireference/API_DetachPolicy.html
Output from Acceptance Testing